Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] fix for inline post when using RUC LSM #877

Closed
wants to merge 3 commits into from
+3 −1
Closed

[production/RRFS.v1] fix for inline post when using RUC LSM #877

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
225dad6
fix for inline post when using RUC LSM
JiliDong-NOAA Oct 11, 2024
5a4180e
pass landsfcmdl to iSF_SURFACE_PHYSICS in post_fv3
JiliDong-NOAA Oct 18, 2024
77603a6
remove redundant declaration
JiliDong-NOAA Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions io/module_write_internal_state.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ module write_internal_state
integer :: ncld !< Number of hydrometeors.
integer :: nsoil !< Number of soil layers.
integer :: imp_physics !< Choice of microphysics scheme.
integer :: landsfcmdl !< Choice of land surface model
integer :: dtp !< Physics timestep.
real,dimension(:),allocatable :: ak !< a parameter for sigma pressure level calculations.
real,dimension(:),allocatable :: bk !< b parameter for sigma pressure level calculations.
Expand Down
4 changes: 3 additions & 1 deletion io/post_fv3.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ subroutine post_getattr_fv3(wrt_int_state,grid_id)
if (trim(attName) == 'nsoil') wrt_int_state%nsoil=varival
if (trim(attName) == 'fhzero') wrt_int_state%fhzero=varival
if (trim(attName) == 'imp_physics') wrt_int_state%imp_physics=varival
if (trim(attName) == 'landsfcmdl') wrt_int_state%landsfcmdl=varival
endif
else if (typekind==ESMF_TYPEKIND_R4) then
if(n==1) then
Expand Down Expand Up @@ -592,6 +593,7 @@ subroutine set_postvars_fv3(wrt_int_state,grid_id,mype,mpicomp)
!
integer i, ip1, j, l, k, n, iret, ibdl, rc, kstart, kend
integer i1,i2,j1,j2,k1,k2
integer landsfcmdl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiliDong-NOAA Do you think this allocation might be unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that. Just to be safe I guess.

integer fieldDimCount,gridDimCount,ncount_field,bundle_grid_id
integer jdate(8)
logical foundland, foundice, found, mvispresent
Expand Down Expand Up @@ -624,7 +626,7 @@ subroutine set_postvars_fv3(wrt_int_state,grid_id,mype,mpicomp)
!
imp_physics = wrt_int_state%imp_physics !set GFS mp physics to 99 for Zhao scheme
dtp = wrt_int_state%dtp
iSF_SURFACE_PHYSICS = 2
iSF_SURFACE_PHYSICS = wrt_int_state%landsfcmdl
spval = 9.99e20
!
! nems gfs has zhour defined
Expand Down