Skip to content

Commit

Permalink
Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.…
Browse files Browse the repository at this point in the history
…3.21) (#3200)

Update the `sorc/syndat_getjtbul.fd/getjtbul.f` code to resolve a problem parsing 3-character storm names.
This update is being included in the GFSv16.3.21 package (with approval by NCO).

From the developer @Qingfu-Liu:

> The `gfs_atmos_tropcy_qc_reloc` job did not properly parse the vitals
info from a raw bulletin with a tab in the storm name field for storm
"SIX". The code sorc/syndat_getjtbul.fd/getjtbul.f converting a tab to a
space worked well for storms that have at least 4 characters in their
names, but does not work as well for storms with 3-character names. This
code change will fix the parsing problem for 3-character storms.

Refs #2591
  • Loading branch information
KateFriedman-NOAA authored Jan 6, 2025
1 parent 3ad6fe1 commit 65f2645
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 5 deletions.
6 changes: 5 additions & 1 deletion docs/Release_Notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ GFS V16.3.21 RELEASE NOTES
PRELUDE
-------

The WAFS is separated from the GFS and is now its own package in production as WAFS.v7.0.1.
The WAFS is separated from the GFS and is now its own package in production as WAFS.v7.0.1. A code update for syndat_getjtbul is also included.

IMPLEMENTATION INSTRUCTIONS
---------------------------
Expand Down Expand Up @@ -60,6 +60,9 @@ The `sorc/build_all.sh` script no longer builds the WAFS code.
The `sorc/build_gfs_wafs.sh` build script is deleted.
The `sorc/link_fv3gfs.sh` script no longer links/copies WAFS files/execs.

Also included in this package is a fix to the syndat_getjtbul code to resolve a
parsing problem with 3-character storm names.

JOBS CHANGES
------------

Expand Down Expand Up @@ -190,3 +193,4 @@ PREPARED BY
[email protected]
[email protected]
[email protected]
[email protected]
16 changes: 12 additions & 4 deletions sorc/syndat_getjtbul.fd/getjtbul.f
Original file line number Diff line number Diff line change
Expand Up @@ -104,27 +104,35 @@ PROGRAM SYNDAT_GETJTBUL
END IF
END DO

IF(INL1(26).EQ.' '.or.INL1(27).EQ.' ') THEN
IF(INL1(25).EQ.' '.or.INL1(26).EQ.' '.or.INL1(27).EQ.' ') THEN

c ... THIS RECORD STILL CONTAINS THE OLD 2-DIGIT FORM OF THE YEAR -
c ... THIS PROGRAM WILL NOW CONVERT THE RECORD TO A 4-DIGIT YEAR USING
c THE "WINDOWING" TECHNIQUE SINCE SUBSEQUENT LOGIC EXPECTS THIS

IF(INL(18:19).EQ.'20') THEN
IF(INL(17:18).EQ.'20') THEN
DUMY2K(1:16) = INL(1:16)
DUMY2K(17:19) = ' '
DUMY2K(20:80) = INL(17:77)
INL= DUMY2K
PRINT *, ' '
PRINT *, '==> This is a record with a 4-digit year'
PRINT *, ' '
ELSE IF(INL(18:19).EQ.'20') THEN
DUMY2K(1:17) = INL(1:17)
DUMY2K(18:19) = ' '
DUMY2K(20:80) = INL(18:78)
INL= DUMY2K
PRINT *, ' '
PRINT *, '==> This is an new-format record with a 4-digit '
PRINT *, '==> This is a record with a 4-digit year'
PRINT *, ' '
ELSE IF(INL(19:20).EQ.'20') THEN
DUMY2K(1:18) = INL(1:18)
DUMY2K(19:19) = ' '
DUMY2K(20:80) = INL(19:79)
INL= DUMY2K
PRINT *, ' '
PRINT *, '==> This is an new-format record with a 4-digit '
PRINT *, '==> This is a record with a 4-digit year'
PRINT *, ' '
ELSE
PRINT *, ' '
Expand Down

0 comments on commit 65f2645

Please sign in to comment.