Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetch job and update stage_ic to work with fetched ICs #3141
base: develop
Are you sure you want to change the base?
Add fetch job and update stage_ic to work with fetched ICs #3141
Changes from all commits
fdb996d
a1f03ec
17f7e6c
a9bd3e2
ba1a017
e624872
fa35c61
f21f96b
20f2862
5ca1531
09ce49c
c71b340
a6dade0
a6a84d4
8aead59
ecc1b48
dd645eb
4ca9d49
df88c29
dd2b726
89c42ef
d0e6f9b
701093c
9433473
04f8da9
d1f2a00
34ae4a8
5c25f26
35f2454
57d01ea
b929200
8e3be40
23b2057
bab00e5
ac86509
60241bd
00e3d62
e7396bc
eba7841
8644449
b7c919e
aae3e6e
2eec8da
939ce24
7afe68c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These host files have extra whitespace in them. Could you please remove that? There should be no difference between these and develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to (for that file) a new line at the end ? I added that as I've read that UNIX tools expect a new line at the end. I can remove it from that file and others to agree with the develop versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the new line character is expected, but most editors put this in automatically. If, after removing these blank lines, we see artifacts indicating that there isn't a new line character at the end of the file, we can diagnose the issue in emacs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the explanation. I will remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed extraneous newlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try adding this to your .emacs file:
Then open, edit (add, then delete a character), and save the file. Lastly, run
xxd
on one of the files and verify that the last hex byte is0A
. This indicates that a new line was written at the end of the file.