Remove 5WAVH from AWIPS GRIB2 parm files #3146
Conversation
…s_atmos_awips_20km_1p0deg.sh
WalterKolczynski-NOAA
changed the title
|
Nevermind, just read more comments in the source issue. |
|
@GwenChen-NOAA Would you mind giving this PR a review? We would like to merge this soon. |
|
I’m at AGU24 meeting this week. I won’t be able to look at it until next week. Is there any test run output to look at?On Dec 11, 2024, at 11:44 AM, Rahul Mahajan ***@***.***> wrote:
@GwenChen-NOAA Would you mind giving this PR a review? We would like to merge this soon.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@ChristopherHill-NOAA @GwenChen-NOAA would like to view the output of the changes to validate and review this PR |
|
@aerorahul @GwenChen-NOAA I am staging the global workflow code in WCOSS2 with the HR4 model output (from 2020103000), and I will attempt to replicate the HR4 post-processing jobs with a test of the PR changes. |
|
@GwenChen-NOAA would like to view the output of the changes to validate and review this PR |
|
Yes, where to find it?
…On Thu, Dec 19, 2024 at 10:29 AM RuiyuSun ***@***.***> wrote:
@GwenChen-NOAA <https://github.com/GwenChen-NOAA> would like to view the
output of the changes to validate and review this PR
—
Reply to this email directly, view it on GitHub
<#3146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWXF3DHBWINGAA7AMZIIFT32GLQ7FAVCNFSM6AAAAABTFRXCSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJUGYZDSOBQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@RuiyuSun and @GwenChen-NOAA : I was unable to complete a test of workflow post-processing jobs before WCOSS2 machine Dogwood was taken offline. I have been attempting to stage the global workflow code and input data on RDHPCS machine Hera to test PR changes there. This effort may be simpler to complete for someone who has recently tested global workflow code on either WCOSS2 or RDHPCS. The code revisions included with this PR can be used to generate test data and to verify whether the "error code 30" from |
|
I won't be able to make a run until WCOSS2/dogwood comes back either. |
|
I conducted a test on Dogwood using the latest workflow, develop branch, and a HRv4 IC(2020060100). The following jobs failed. gfs_gempakgrb2spec* jobs didn't get started. Please see below for the experiment dirs: |
|
I am running a test based on Chris's branch and will post result here. |
|
@RuiyuSun @ChristopherHill-NOAA I have made a few fixes to the downstream jobs in #3187 that also address issues indicated in #3019. |
|
@DavidHuber-NOAA Great! Thanks for the update.
|
The test finished with a few failures. Please see below for the failed tasks: gfs_gempakncdcupapgif (failed) Information about the test: |
@ChristopherHill-NOAA Is this good enough to prove that your changes worked? Do we need anything else to proceed with this? |
@RuiyuSun According to the log file I was not able to verify the content of the gfsawips_20km_1p0deg output files before they were scrubbed from ptmp space. Please let me know if these output files were saved in HPSS or elsewhere. The failures associated with |
@ChristopherHill-NOAA I didn't see any failure with awips jobs. All the failed jobs are listed below. gfs_gempakncdcupapgif (failed) |
Unfortunately, I didn't save the data. |
|
@ChristopherHill-NOAA @RuiyuSun I am OK with merging this when you deem it ready and I will continue the effort in #3187. |
@DavidHuber-NOAA Since the targeted workflow tasks were observed to run to successful completion with the PR changes during the test run by @RuiyuSun, we agree with proceeding with the merge of this PR. |
* develop: Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246) Add domain level to wave gridded COM path (NOAA-EMC#3137) CI JJOB Tests using CMake (NOAA-EMC#3214) Make assorted updates to waves (NOAA-EMC#3190) Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236) Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211) Add additional GEFS variables needed for AI/ML applications (NOAA-EMC#3221) Add bmat task dependency to marine LETKF task (NOAA-EMC#3224) Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206) Separate use of initial increment/perturbation file from REPLAY/+03 ICs (NOAA-EMC#3119) Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207) Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212) Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146) Remove multi-grid wave support (NOAA-EMC#3188) Add echgres as a dependency for earc (NOAA-EMC#3202)
Description
As referred within #3019, the variable 5WAVH is being removed from each of the files
parm/wmo/grib2_awpgfs[000-240].003andparm/wmo/grib2_awpgfs_20km_[ak,conus,pac,prico]f000for the purpose of remedying "error code 30" that was generated through the execution ofexgfs_atmos_awips_20km_1p0deg.shduring the GFSv17 HR4 test run. Obsolete code is also being removed from the scriptexgfs_atmos_awips_20km_1p0deg.sh.No other errors mentioned in #3019 are addressed in this PR.
Type of change
Change characteristics
(If YES, please add a link to any PRs that are pending.)
How has this been tested?
Removal of variable 5WAVH from the GRIB2 files should allow completion of TOCGRIB2 processing (within
exgfs_atmos_awips_20km_1p0deg.sh) of the GRIB2 files. @RuiyuSun, or the GW team, may wish to include the requested modifications for future GFSv17 tests that include post-processing jobs.Checklist