Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update g-w to cycle with C1152 ATM #3206

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Update g-w to cycle with C1152 ATM #3206

merged 6 commits into from
Jan 10, 2025

Conversation

CatherineThomas-NOAA
Copy link
Contributor

Description

There are a few updates needed to cycle with the C1152 atmospheric model:

Note that any needed changes to time limits for C1152 will be addressed at a later date.

Resolves #3173

Type of change

  • New feature (adds functionality)

Change characteristics

How has this been tested?

  • Cycled C1152/C384 ATM-only on WCOSS2

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

CatherineThomas-NOAA and others added 4 commits December 19, 2024 09:31
@CatherineThomas-NOAA
Updates for cycling C1152 ATM
87db086 
A handful of updates are needed to cycle with C1152
atmosphere, which are mostly related to configs and
resources.

Refs: NOAA-EMC#3173
@CatherineThomas-NOAA
Merge branch 'NOAA-EMC:develop' into c1152_cyc
7c3a155
@CatherineThomas-NOAA
Merge branch 'NOAA-EMC:develop' into c1152_cyc
9c1b856
@CatherineThomas-NOAA
Update gsi_utils hash for C1152 cycling
c7b3010 
The calc_analysis utility was updated to handle the
increased horizontal resolution of C1152 ATM.

Refs: NOAA-EMC#3173
aerorahul
aerorahul previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Jan 6, 2025
@aerorahul
Copy link
Contributor

Running the CI on Hera and Hercules to cover the gsi-utils hash update. The other changes will not be tested in the CI

@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 6, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gdas_analcalc.log
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gfs_analcalc.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_c7b3010b

@RussTreadon-NOAA
Copy link
Contributor

The gfs and gdas analcalc failures in C96C48_ufs_hybatmDA are true errors.

calc_anl.x aborts with

 Computing and Adding Surface Pressure Increment
 rank of data array != variable ndims (or ndims-1)
...
 rank of data array != variable ndims (or ndims-1)
99
srun: Received task exit notification for 31 tasks of StepId=4860606.2 (status=0x6300).
srun: error: h6c28: tasks 96-126: Exited with exit code 99

when processing ensemble resolution files.

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Failed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3206


Experiment C48_ATM_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:10:21 UTC 2025
Experiment C96C48_ufs_hybatmDA_c7b3010b Terminated with 0
FAIL
FAIL tasks failed and 2 dead at Tue Jan  7 00:16:16 UTC 2025
Experiment C96C48_ufs_hybatmDA_c7b3010b Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gdas_analcalc.log
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gfs_analcalc.log
Experiment C48mx500_3DVarAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:16:30 UTC 2025
Experiment C48mx500_hybAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:23:23 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_c7b3010b Completed 1 Cycles: *SUCCESS* at Tue Jan  7 00:23:35 UTC 2025
Experiment C96C48_hybatmDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:29:07 UTC 2025
Experiment C96C48_hybatmaerosnowDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:29:39 UTC 2025
Experiment C96_atm3DVar_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:35:12 UTC 2025
Experiment C48_S2SW_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 02:26:29 UTC 2025
Experiment C48_S2SWA_gefs_c7b3010b Completed 1 Cycles: *SUCCESS* at Tue Jan  7 02:57:23 UTC 2025

@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3206


Experiment C48_ATM_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:39:25 CST 2025
Experiment C48mx500_3DVarAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:45:33 CST 2025
Experiment C48mx500_hybAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:51:44 CST 2025
Experiment C96_S2SWA_gefs_replay_ics_c7b3010b Completed 1 Cycles: *SUCCESS* at Mon Jan  6 18:34:41 CST 2025
Experiment C96_atm3DVar_c7b3010b Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:46:13 CST 2025
Experiment C96C48_hybatmDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:46:30 CST 2025
Experiment C48_S2SW_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 19:23:11 CST 2025
Experiment C48_S2SWA_gefs_c7b3010b Completed 1 Cycles: *SUCCESS* at Mon Jan  6 21:19:23 CST 2025

@RussTreadon-NOAA
Copy link
Contributor

Examine the guess and increment files read by the calc_analysis code. GSI based atmospheric increment files contain

float delp_inc(lev, lat, lon) ;

whereas GDASApp based atmospheric increment files contain

        double delp_inc(time, lev, lat, lon) ;

GDASApp increment files add a time dimension to the increment array.

This was referenced Jan 7, 2025
Closed
Merged
@RussTreadon-NOAA
Copy link
Contributor

@CatherineThomas-NOAA , the sorc/gsi_utils.fd hash in CatherineThomas-NOAA:c1152_cyc can be updated to f716012.

The changes in f716012 have been tested in g-w CI C96C48_hybatmDA and C96C48_ufs_hybatmDA on Cactus. gfs_analcalc and gdas_analcalc successfully ran to completion in both configurations.

@CatherineThomas-NOAA
Update gsi_utils for C1152 cycling
a161bf2 
The original calc_analysis bugfix was not suitable for
JEDI-based ATM DA.  This hash update allows for
calc_analysis to work with both GSI and JEDI-based ATM DA.

Resolves NOAA-EMC#3173
@CatherineThomas-NOAA
Copy link
Contributor Author

Thanks @RussTreadon-NOAA for the gsi_utils update.

I tested the gsi_utils update in my C1152 exp and had no issues. I've updated my fork with the new gsi_utils hash as well as merged in the latest g-w develop. I think this PR is ready to retest @aerorahul.

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 8, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 8, 2025
@aerorahul aerorahul added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Jan 8, 2025
@emcbot emcbot added the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Jan 8, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Jan 8, 2025
@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Jan 8, 2025
@emcbot
Copy link

emcbot commented Jan 8, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3206/RUNTESTS on WCOSS

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 9, 2025
@WalterKolczynski-NOAA
Copy link
Contributor

This passed on Hera but the label didn't get set.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ed95546 into NOAA-EMC:develop Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul left review comments

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates for cycling C1152 ATM
6 participants
@CatherineThomas-NOAA @aerorahul @emcbot @RussTreadon-NOAA @WalterKolczynski-NOAA @KateFriedman-NOAA