Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn IAU off during staging job for cold start experiments #3215

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Turn IAU off during staging job for cold start experiments #3215

merged 4 commits into from
Jan 14, 2025

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR resolves a bug related to IAU when cold-starting an experiment. The model start time for non-atmos ICs were incorrectly being reduced by 3hrs. While a user may want IAU on (DOIAU=YES), the IAU/DOIAU should be set to "NO" for the staging job since it is cold-started. The forecast job that follows that staging job correctly sets the model start time, which now matches what the staging job will set and pick up.

If cold-starting (EXP_WARM_START=.false.) then config.stage_ic will set DOIAU=NO for only the staging job. Added the same check to the GEFS config.stage_ic since the GEFS configs still support IAU settings.

This change resolves the staging issue reported in issue #2890. Testing for issue #2865 also shows the issue is resolved for the staging and the testing makes it to the next cycle but the test case has issues in other areas. Need a clean fully coupled cold-start case to 100% sure but one does not currently exist in the PR cases. Happy to test further if provided a case.

Resolves #2890
Resolves #2865

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

New if-block added to staging configs.

How has this been tested?

Two cycled tests on Hera using the cases provided in the relevant issues.

KateFriedman-NOAA and others added 2 commits January 8, 2025 17:30
@KateFriedman-NOAA
Turn off IAU in staging job when cold started
cc83660 
Fixes issue with incorrectly setting model_start time
for initial condition filenames when cold starting.

Refs NOAA-EMC#2865
Refs NOAA-EMC#2890
@KateFriedman-NOAA
Merge branch 'NOAA-EMC:develop' into feature/doiau_cold_start
f7935f5
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Jan 8, 2025
@WalterKolczynski-NOAA
Copy link
Contributor

What about replay?

@KateFriedman-NOAA
Copy link
Member Author

What about replay?

@WalterKolczynski-NOAA Do you mean the C96_S2SWA_gefs_replay_ics.yaml CI test?

@WalterKolczynski-NOAA
Copy link
Contributor

Nevermind, replay would be warm start anyway.

@KateFriedman-NOAA KateFriedman-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Jan 13, 2025
@emcbot emcbot added the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Jan 13, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Jan 13, 2025
@emcbot emcbot added the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Jan 13, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Jan 13, 2025
@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Jan 13, 2025
@emcbot
Copy link

emcbot commented Jan 13, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3215/RUNTESTS on WCOSS

@KateFriedman-NOAA KateFriedman-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Jan 13, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 13, 2025
@emcbot emcbot added the CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully label Jan 14, 2025
@emcbot
Copy link

emcbot commented Jan 14, 2025

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3215


Experiment C48mx500_3DVarAOWCDA_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 21:48:48 UTC 2025
Experiment C48_ATM_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 21:48:48 UTC 2025
Experiment C48mx500_hybAOWCDA_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 21:54:53 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_6aec3383 Completed 1 Cycles: *SUCCESS* at Mon Jan 13 22:01:32 UTC 2025
Experiment C96C48_hybatmDA_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 23:16:20 UTC 2025
Experiment C96C48_hybatmaerosnowDA_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 23:16:20 UTC 2025
Experiment C96_atm3DVar_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 23:20:13 UTC 2025
Experiment C96C48_ufs_hybatmDA_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 23:46:45 UTC 2025
Experiment C48_S2SW_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 23:59:12 UTC 2025
Experiment C48_S2SWA_gefs_6aec3383 Completed 1 Cycles: *SUCCESS* at Tue Jan 14 00:35:16 UTC 2025

@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Jan 14, 2025
@emcbot
Copy link

emcbot commented Jan 14, 2025

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3215


Experiment C48_ATM_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 15:05:10 CST 2025
Experiment C48mx500_3DVarAOWCDA_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 15:11:34 CST 2025
Experiment C48mx500_hybAOWCDA_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 15:17:50 CST 2025
Experiment C96_S2SWA_gefs_replay_ics_6aec3383 Completed 1 Cycles: *SUCCESS* at Mon Jan 13 15:54:25 CST 2025
Experiment C96C48_hybatmDA_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 16:06:18 CST 2025
Experiment C96_atm3DVar_6aec3383 Completed 3 Cycles: *SUCCESS* at Mon Jan 13 16:12:18 CST 2025
Experiment C48_S2SW_6aec3383 Completed 2 Cycles: *SUCCESS* at Mon Jan 13 17:13:20 CST 2025
Experiment C48_S2SWA_gefs_6aec3383 Completed 1 Cycles: *SUCCESS* at Mon Jan 13 18:44:12 CST 2025

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Jan 14, 2025
@KateFriedman-NOAA KateFriedman-NOAA merged commit 53ed76e into NOAA-EMC:develop Jan 14, 2025
5 checks passed
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/doiau_cold_start branch January 14, 2025 14:11
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Jan 15, 2025
@KateFriedman-NOAA
Merge remote-tracking branch 'upstream/develop' into feature/jgdas_en…
583e738 
…kf_sfc_update_com_in_out

* upstream/develop:
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Jan 15, 2025
@KateFriedman-NOAA
Merge remote-tracking branch 'upstream/develop' into feature/jgdas_en…
3f7d555 
…kf_sfc_update_com_in_out

* upstream/develop:
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Jan 15, 2025
@KateFriedman-NOAA
Merge remote-tracking branch 'upstream/develop' into feature/jgdas_en…
02e810e 
…kf_sfc_update_com_in_out

* upstream/develop:
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
tsga added a commit to tsga/global-workflow that referenced this pull request Jan 22, 2025
@tsga
Merge branch 'develop' into feature/lnd_regrid_iau
dbebb2e 
* develop:
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA

Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
3 participants
@KateFriedman-NOAA @WalterKolczynski-NOAA @emcbot