Add sfs as valid system #3243
Open
Add sfs as valid system #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterKolczynski-NOAA
requested review from
DavidHuber-NOAA,
aerorahul and
TerrenceMcGuinness-NOAA
as code owners
|
@NeilBarton-NOAA would you please supply ICs for the SFS test so we can set it up to run on all systems |
|
Still need to add SFS to the RTD documentation. |
WalterKolczynski-NOAA
force-pushed
the
feature/sfs
branch
from
a1356d1 to
873ea5c
Compare
|
ICs are in place and documentation has been updated. Ready for review. |
Adds sfs as a valid option for NET. To start, the GEFS system is generally just copied wholesale for SFS. This includes the extract_vars job. Other than base and resources, config files link to the GEFS versions, just as GEFS config files point to the GFS versions except where they have needed to be changed. The temporarily SFS_POST option has been removed. The sfs test case is moved from a separate sfs directory to the pr directory, but ICs are still needed before it is functional. Resolves NOAA-EMC#2271
The SFS case is moved back to its original position in an sfs directory, then a copy is made in the PR directory using a shorter time period and a couple other changes.
WalterKolczynski-NOAA
force-pushed
the
feature/sfs
branch
from
574ca9d to
2bbef76
Compare
EricSinsky-NOAA
requested changes
Jan 28, 2025
| tasks += ['wavepostpnt'] | ||
|
|
||
| if options['do_extractvars']: | ||
| tasks += ['extractvars', 'arch'] |
There was a problem hiding this comment.
Suggested change
| tasks += ['extractvars', 'arch'] | |
| tasks += ['extractvars'] |
There was a problem hiding this comment.
Should the arch task be created even when do_extractvars is false? This change has recently been applied to gefs.py.
| if options['do_extractvars']: | ||
| tasks += ['extractvars', 'arch'] | ||
|
|
||
| tasks += ['cleanup'] |
There was a problem hiding this comment.
Suggested change
| tasks += ['cleanup'] | |
| tasks += ['arch', 'cleanup'] |
There was a problem hiding this comment.
If the arch task were to be added unconditionally, will a sfs_arcdir.yaml.j2 and master_sfs.yaml.j2 need to be created for the archive task to succeed?
| max_tasks = self._configs[config]['MAX_TASKS'] | ||
| resources = self.get_resource(config) | ||
|
|
||
| fhrs = self._get_forecast_hours('gefs', self._configs[config], component) |
There was a problem hiding this comment.
Suggested change
| fhrs = self._get_forecast_hours('gefs', self._configs[config], component) | |
| fhrs = self._get_forecast_hours('sfs', self._configs[config], component) |
|
|
||
| dependencies = rocoto.create_dependency(dep_condition='and', dep=deps) | ||
|
|
||
| fhrs = self._get_forecast_hours('gefs', self._configs['atmos_ensstat']) |
There was a problem hiding this comment.
Suggested change
| fhrs = self._get_forecast_hours('gefs', self._configs['atmos_ensstat']) | |
| fhrs = self._get_forecast_hours('sfs', self._configs['atmos_ensstat']) |
| deps.append(rocoto.add_dependency(dep_dict)) | ||
| dependencies = rocoto.create_dependency(dep=deps, dep_condition='or') | ||
|
|
||
| fhrs = self._get_forecast_hours('gefs', self._configs['wavepostsbs'], 'wave') |
There was a problem hiding this comment.
Suggested change
| fhrs = self._get_forecast_hours('gefs', self._configs['wavepostsbs'], 'wave') | |
| fhrs = self._get_forecast_hours('sfs', self._configs['wavepostsbs'], 'wave') |
|
|
||
| # Resolution specific parameters | ||
| export LEVS=128 | ||
| export CASE="@CASECTL@" # CASE is required in GEFS to determine ocean/ice/wave resolutions |
There was a problem hiding this comment.
CASE is also required for SFS, right?
Suggested change
| export CASE="@CASECTL@" # CASE is required in GEFS to determine ocean/ice/wave resolutions | |
| export CASE="@CASECTL@" # CASE is required in SFS to determine ocean/ice/wave resolutions |
|
|
||
| # Commonly defined parameters in JJOBS | ||
| export envir=${envir:-"prod"} | ||
| export NET="sfs" # NET is defined in the job-card (ecf) |
There was a problem hiding this comment.
Since NET is set to sfs, archive.py might fail at lines 89-90 if the sfs yaml does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds sfs as a valid option for NET.
To start, the GEFS system is generally just copied wholesale for SFS. This includes the extract_vars job.
Other than base and resources, config files link to the GEFS versions, just as GEFS config files point to the GFS versions except where they have needed to be changed.
The temporary SFS_POST option has been removed.
The existing SFS test is copied and slightly modified for a PR-level CI test.
Resolves #2271
Type of change
Change characteristics
How has this been tested?
Checklist