Improve timestamp adjustment function in Glorys obc generation workflow #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-cordero
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users have reported that the timestamp adjustment function in the current OBC workflow disrupts the original time variables and attributes, and will eventually mess up model run. This PR aims to address the issue by using
decode_times=Falsewhen reading the files. Additionally, we have modified several boundary generation codes to further preserve the original time attributes and encoding.UPDATES
I tested the updated workflow with the ARCTIC physics-only case shared by @theresa-morrison, and the new OBC files generated from it ran successfully through the year 1993.
The example obc generation workflow for Arctic can be found on ppan:
/work/ynt/develop/20250124/new/CEFI-regional-MOM6/tools/boundary/glorys_obc_workflow/mom6_obc_workflow_arctic.shThe Arctic 1-month test case can be found here:
/gpfs/f6/ira-cefi/proj-shared/ARC12_nofk_nsrwsp_newobcs__1.o207690353