-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2b - remove flux exchange clocks #111
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
changed the title
3b - remove flux exchange clocks
2b - remove flux exchange clocks
Apr 18, 2024
Closing this PR, a discussion might be required before removing the clocks in fluxes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the following clocks have been removed.
In
atm_land_ice_flux_exchange_mod: sfcClock, fluxAtmDnClock, regenClock, fluxAtmUpClock
ice_ocean_flux_exchange_mod: fluxOceanIceClock, fluxIceOceanClock
land_ice_flux_exchange_mod: fluxLandIceClock
These clocks are unnecessary since similar temporal information can be gathered from the clocks set in the coupler_main program.
With these changes runtime summaries labeled as
Land-ice-atm coupler
,SFC boundary layer
andIce-ocean coupler
are not written out to stdout. These statistics are captured influx_exchange_init
,generate_sfc_xgrid
,flux_ocean_to_ice
andflux_ice_to_ocean
.This PR addresses Issue #110