13 - coupler_intermediate restart #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coupler_update_atmos_model_radiation coupler_update_atmos_model_down coupler_flux_down_from_atmos
update_ice_model_fast coupler_flux_up_to_atmos coupler_update_atmos_model_up coupler_flux_atmos_to_ocean
… atmos_model-flux_down
rem1776
requested changes
Jun 21, 2024
uramirez8707
approved these changes
Jun 21, 2024
rem1776
previously approved these changes
Jun 21, 2024
thomas-robinson
requested changes
Jun 21, 2024
full/coupler_main.F90
Outdated
| @@ -446,7 +442,8 @@ program coupler_main | |||
| if (check_stocks >= 0) call coupler_flux_init_finish_stocks(Time, Atm, Land, Ice, Ocean_state, & | |||
| coupler_clocks, init_stocks=.True.) | |||
|
|
|||
| do nc = 1, num_cpld_calls | |||
| !> ocean/slow-ice integration loop | |||
| slow_integration_loop : do nc = 1, num_cpld_calls | |||
There was a problem hiding this comment.
This should be named something like coupled_timestep_loop because it’s the coupled timestep
full/full_coupler_mod.F90
Outdated
| @@ -1343,7 +1354,7 @@ subroutine coupler_restart(Atm, Ice, Ocean, Ocn_bc_restart, Ice_bc_restart, & | |||
| type(FmsNetcdfDomainFile_t), dimension(:), pointer, intent(inout) :: Ocn_bc_restart | |||
| type(FmsNetcdfDomainFile_t), dimension(:), pointer, intent(inout) :: Ice_bc_restart | |||
|
|
|||
| type(FmsTime_type), intent(in) :: Time_run, Time_res, Time_start, Time_end | |||
| type(FmsTime_type), intent(in) :: Time_current, Time_restart_current, Time_start | |||
There was a problem hiding this comment.
These variables need to be documented
|
@thomas-robinson if you do not want to include the restart changes, then this PR does not need to be merged. Refactorization is done for now. |
added 2 commits
June 25, 2024 13:12
thomas-robinson
approved these changes
Jun 25, 2024
rem1776
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the subroutine
coupler_intermediate_restartandcoupler_summarize_timestephve been defined and is used in coupler_main.AM4, CM4, SPEAR, and OM4 experiments pass.