revise do_flux logic #134
Merged
revise do_flux logic #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle reminder about this. |
rem1776
approved these changes
Jul 18, 2024
|
@JosephMouallem Thanks for the fix, we should be able to get this in for the next release (2024.03). It's scheduled for early august. |
bensonr
approved these changes
Jul 18, 2024
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when do_flux=.F.
Currently
do_fluxis only invoked when callingcoupler_sfc_boundary_layer.When do_flux is off, calls to
coupler_flux_down_from_atmos,coupler_flux_up_to_atmosandcoupler_flux_atmos_to_oceanwill cause a code crash since they depend on exchange grid quantities/fluxes allocated and set up bysfc_boundary_layerThis has been tested with the new version of SHiELD employing the new coupler.