Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #302 #317

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Revert #302 #317

merged 1 commit into from
Jan 26, 2024

Conversation

spencerkclark
Copy link
Member

Description

Per offline discussion with @lharris4, the fix made in #302 may not be scientifically correct. This PR reverts that change for now, though reopens #301.

How Has This Been Tested?

There is not really an easy way to test this other than that the code compiles, which should be covered by CI.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bensonr
Copy link
Contributor

bensonr commented Jan 25, 2024

@lharris4 - if you are okay with this, I'll merge it as soon as the checks finish.

@spencerkclark
Copy link
Member Author

@bensonr, while I have you, could you go ahead and merge #316? Thanks!

@spencerkclark spencerkclark marked this pull request as ready for review January 25, 2024 21:10
@bensonr
Copy link
Contributor

bensonr commented Jan 25, 2024

@spencerkclark - if you'd like me to revert #302, I can simply press a button and it will take that change out. I don't think we need a this PR.

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this change. I may need to take a closer look at what would be a better way to handle this.

@bensonr bensonr merged commit 9ca1468 into NOAA-GFDL:main Jan 26, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants