Rescale 6 ice shelf variables #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
the
refactor
alex-huth
reviewed
Jan 22, 2025
alex-huth
reviewed
Jan 22, 2025
alex-huth
reviewed
Jan 22, 2025
alex-huth
reviewed
Jan 22, 2025
Changed the rescaling of 7 ice shelf variables to cancel out common conversion factors that appear in several expressions. The C_basal_friction argument to initialize_ice_C_basal_friction is now in partially rescaled units, reflecting the portion that does not cancel out fractional-power units from a power law fit with an arbitrary power. The C_basal_friction array in ice_shelf_dyn_CS and the C_friction variable in initialize_ice_C_basal_friction were similarly rescaled. There are new scale factors in a get_param_call and a MOM_read_data call and a conversion factor in register_restart_field call that reflect these changes. The KE_tot and mass_tot variables in write_ice_shelf_energy, are kept in scaled units until they are written. The internal variable fN in calc_shelf_taub is kept in scaled units, but there is now a scaling factor of US%L_to_N in the expression for fB. This latter could be folded into the CF_Max element of ice_shelf_dyn_CS, but I am unsure whether this would be physically sensible. All answers should be bitwise identical and no output should change, but this has not been extensively tested yet.
Hallberg-NOAA
force-pushed
the
more_ice_shelf_rescaling
branch
from
d308d24 to
29642ad
Compare
|
Thank you for the detailed review @alex-huth . This PR has now been updated in line with all of the suggestions. |
alex-huth
approved these changes
Jan 23, 2025
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the rescaling of 6 ice shelf variables to cancel out common conversion factors that appear in several expressions.
The
C_basal_frictionargument toinitialize_ice_C_basal_friction()is now in partially rescaled units, reflecting the portion that does not cancel out fractional-power units from a power law fit with an arbitrary power. TheC_basal_frictionarray inice_shelf_dyn_CSand theC_frictionvariable ininitialize_ice_C_basal_friction()were similarly rescaled. There are new scale factors in aget_param()call and aMOM_read_data()call and a conversion factor in aregister_restart_field()call that reflect these changes.The
KE_totandmass_totvariables inwrite_ice_shelf_energy(), are kept in scaled units until they are written.The internal variable
fNin calc_shelf_taub()is kept in scaled units, but there is now a scaling factor ofUS%Z_to_Lin the expression forfB. This latter could be folded into theCF_Maxelement ofice_shelf_dyn_CS`, but I am unsure whether this would be physically sensible.All answers should be bitwise identical and no output should change, but this has not been extensively tested yet.