Icepack area underflow patch #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ero, which preserves previous behavior which resulted in extremely small negative ice volumes in subsequent calls to ice_continuity, resulting in model failure. This parameter can be set to a reasonable value (e.g. 10^-30) to avoid this scenario.
MitchBushuk
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Thanks @MJHarrison-GFDL for putting this ice area underflow fix in.
MitchBushuk
approved these changes
Oct 3, 2022
marshallward
reviewed
Oct 3, 2022
marshallward
reviewed
Oct 3, 2022
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/16960 ✔️ I will squash-merge this PR. |
marshallward
approved these changes
Oct 4, 2022
|
I'm afraid you have to check for negative ice volume as well. I get: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New parameter RIDGE_AREA_UNDERFLOW is introduced in order to avoid the occurrence of undetectably small fractional area and negative ice volume following ridging adjustments from Icepack. The default is 0.0, which does not introduce changes in existing runs. A reasonable value would be 10^-26 which would correspond to an Angstrom-scale ice patch within a km-scale grid cell. This addresses #178 and #183