Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitted 'override' on BMI methods #6

Merged

Conversation

PhilMiller
Copy link
Contributor

See NOAA-OWP/ngen#827

Changes

  • Add override on all BMI methods, and remove virtual on them, since it would then potentially look like declaration of a new virtual method.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@hellkite500 hellkite500 merged commit 27350d8 into NOAA-OWP:master May 31, 2024
1 of 2 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/Wsuggest-override branch May 31, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants