Nash Cascade Refactoring #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkhattak - Are there any tests you recommend running for the sake of sanity? e.g. SMP coupling? -thanks |
|
@madMatchstick if you can run our existing tests on your machine, which includes coupling to SMP too (AET_ROOTZONE test), to compare results with and without the refactored code that would be nice. |
madMatchstick
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Ran pseudo-framework mode with option AETROOTZONE & results were identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nash cascade part is taken out from the
cfe.cand added as a separate .c file, so it can also be used for surface runoff, and in other models (e.g., LASAM) as well. No changes to the functionality in this PR.Changes
nash_cascadefromcfe.cto newly addednash_cascade.cfileTesting
Checklist