Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added retention_depth to calibrated params #123

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Added retention_depth to calibrated params #123

merged 2 commits into from
Jul 12, 2024

Conversation

ajkhattak
Copy link
Contributor

The PR adds a new parameter retention_depth_surface_nash to the calibratable parameters list per Fred's request.

Additions

  • added a calibratable parameter

Removals

  • None

Changes

  • None

Testing

  1. All existing tests passed

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • Reviewers requested with the Reviewers tool ➡️

@ajkhattak ajkhattak requested a review from madMatchstick July 12, 2024 16:59
madMatchstick
madMatchstick approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test pass. Thanks for adding the new parameter to the listing in the unit test!

@ajkhattak ajkhattak merged commit 14f334a into master Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madMatchstick madMatchstick madMatchstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajkhattak @madMatchstick