Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT/DISCUSSION: Profiling modifications #425

Closed
wants to merge 2 commits into from

Conversation

mattw-nws
Copy link
Contributor

How do we (do we?) want to manage a profiling version of ngen? Dev branch? Macros? Replace with better external tool than callgrind?

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@donaldwj
Copy link
Contributor

donaldwj commented Aug 4, 2022

The primary difference between the internal profiling and call grind is the internal tools have a much lower time cost but only provide data about broad categories of execution.

@PhilMiller
Copy link
Contributor

Some of this got done in #696 and other bits will need to be reworked, and won't be that hard anyway.

@PhilMiller PhilMiller closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants