Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alm log write statements in new helper function, raise optimization warning instead of ValueError #32

Merged
merged 3 commits into from
May 12, 2021

Conversation

kilojoules
Copy link
Contributor

I write statements from the depreciated update actuator line function. I think this resolves issue #30 #30. I changed a ValueError to a warning, to allow monitoring of power without performing optimization. I think this partially resolves issue #31 #31.

@johnjasa
Copy link
Collaborator

@eyoung55, it looks like the CI hanged and canceled here. Would you expect this behavior given what you recently found? Do we need to change something here or can we just rerun the CI and expect it to pass?

@eyoung55
Copy link
Collaborator

eyoung55 commented May 12, 2021

yeah, if i'm reading the log progress right, the place where it was hanging was a little weird, but i wouldn't be too surprised if it was the same underlying issue. @kilojoules, can you merge in the upstream changes from the dev branch so we can retest this (@johnjasa, am i saying that right?)? Dev also now has some safer versions of the folder-creation steps that hold the output files, so it's probably a useful thing all around.

@johnjasa
Copy link
Collaborator

Nice, I've pushed those changes from dev to this PR

@eyoung55
Copy link
Collaborator

Looking good! Let's merge it!

@johnjasa johnjasa merged commit f0b68db into NREL:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants