Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of duplicate params #49

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fix handling of duplicate params #49

merged 3 commits into from
Jul 31, 2024

Conversation

ppinchuk
Copy link
Collaborator

Thanks for finding this @bnb32!

@ppinchuk ppinchuk added documentation Improvements or additions to documentation bugfix Fixed a known bug labels Jul 31, 2024
@ppinchuk ppinchuk self-assigned this Jul 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (af6faee) to head (0856d67).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          29       29           
  Lines        2898     2898           
  Branches      491      491           
=======================================
  Hits         2835     2835           
  Misses         39       39           
  Partials       24       24           
Flag Coverage Δ
unittests 97.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 62b5a3f into main Jul 31, 2024
15 checks passed
@ppinchuk ppinchuk deleted the pp/duplicate_params branch July 31, 2024 20:19
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Fix handling of duplicate params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed a known bug documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants