-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Cached with Yolox-graphic-elements and drop Deplot #365
base: main
Are you sure you want to change the base?
Conversation
…v/nv-ingest into edwardk/replace-cached-with-yolox-1
…v/nv-ingest into edwardk/replace-cached-with-yolox-1
capabilities: [gpu] | ||
runtime: nvidia | ||
|
||
deplot: | ||
image: ${DEPLOT_IMAGE:-nvcr.io/nvidia/nemo-microservices/deplot}:${DEPLOT_TAG:-1.0.0} | ||
yolox-graphic-elements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misreading GitHub's review changes UI, but can we put this new NIM on device 1, since 0 is overloaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to have Deplot on device 0, but we can remove Deplot with this PR, so I moved everything to device 0 including this new NIM. Isn't that what we wanted to do by dropping Deplot, i.e., fit everything in 1 device and drop the minimum requirement to 1 GPU?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is one goal, but we should do that subject to more benchmarking. we don't yet have the ability to set the batch size, and I'd like to confirm we're not saturating compute capacity of a single device (for good portion of bo767 execution, both GPUs have >50% utilization).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, moved the new nim to device 1 in b5fd7fa.
Description
Checklist