Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Cached with Yolox-graphic-elements and drop Deplot #365

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

edknv
Copy link
Collaborator

@edknv edknv commented Jan 21, 2025

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

capabilities: [gpu]
runtime: nvidia

deplot:
image: ${DEPLOT_IMAGE:-nvcr.io/nvidia/nemo-microservices/deplot}:${DEPLOT_TAG:-1.0.0}
yolox-graphic-elements:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misreading GitHub's review changes UI, but can we put this new NIM on device 1, since 0 is overloaded?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have Deplot on device 0, but we can remove Deplot with this PR, so I moved everything to device 0 including this new NIM. Isn't that what we wanted to do by dropping Deplot, i.e., fit everything in 1 device and drop the minimum requirement to 1 GPU?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is one goal, but we should do that subject to more benchmarking. we don't yet have the ability to set the batch size, and I'd like to confirm we're not saturating compute capacity of a single device (for good portion of bo767 execution, both GPUs have >50% utilization).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, moved the new nim to device 1 in b5fd7fa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants