Update from develop #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-net-solr net/solr: enhance explanatory comment
Add multiple scenarios for TestListEADFilesForCommit()
Add defensive programming check if both "from" and "to" file arguments are nil. This shouldn't happen, but added a case to the switch that returns and "Unknown" action anyway.
Add a pure file-update case to TestListEADFilesForCommit() Add update case and better error handling to repo-generator script Update simple-repo.tar.gz with update case
Update comments. Change single quotes to double quotes in commit messages.
Update simple-repo.tar.gz with new commit message quoting. (The single quotes around the EADID value in the delete commit message were not making it into the git commit history due to a quoting bug in the gen-repo.bash script.)
Change IndexerOperation type from int to string to have more descriptive error messages. Update constant Add, Delete, Unknown values to be strings. Change multi-error Join delimiter to a "\n" from ";". Update commit hashes used in TestListEADFilesForCommit() to reflect latest state of the simple-repo test fixture. Add call to teardownRepo() at the beginning of TestListEADFilesForCommit() to cleanup any leftovers from interrupted test runs.
Add check to see if target repo already exists. If so, exit with warning.
…age-git DLFA-222: add ListEADFilesForCommit()
…age-git update ListEADFilesForCommit() to use errors.Join
da70
merged commit fea1e79
into
dlfa-232-go-ead-indexer-package-net-solr
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to get git/ stuff