-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug ValueError by Voikko analyzer #738
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6404 6429 +25
=======================================
+ Hits 6383 6408 +25
Misses 21 21
☔ View full report in Codecov by Sentry. |
I think it would be helpful to be able to log more contextual information, but this might be a bit difficult since it would require accessing the call stack. At least in the traceback in #737 it seems that the error got triggered via the MLLM backend. So in that case it would be good to log the sentence that was being tokenized and maybe even the whole document text. |
9adcf18
to
7560fff
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Now the text being tokenized (full document) should be logged too. |
I build a Docker image from this branch, deployed it to ai.dev.finto.fi and started sending suggest requests continuously with Annif-client (with contents from Kirjastonhoitaja dataset documents). Hopefully the error occurs and we get some more clues about it. I thought using some fuzzing tool, but this was an easy way. Maybe this PR does not even need to be merged to main, if the root cause of the error and a fix to it can be found. |
I think that text extracted from random PDFs, ideally using different text extraction tools, might be a better (more fuzzy) data source. But this is a good start, let's see if it will trigger the bug. |
This aims to help to debug why the ValueError by Voikko analyzer arises (#737).
When this is merged, the latest Docker image could be deployed to ai.dev.finto.fi, which could then be used to investigate the situation.
Is there anything else that could be logged, in addition to the triggering word, @osma?