[FINNA-2476] LIDO: add video download link and video/audio file information #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link added. Displayed when lido.
pasitiis
reviewed
Sep 25, 2024
| @@ -80,6 +82,10 @@ | |||
| <?=$this->icon('video-play', 'video-play-icon') ?> | |||
| <span class="video-desc"><?=$this->escapeHtml($this->truncate(ucfirst($desc), 30))?></span> | |||
| </finna-video> | |||
| <?php if ($showDetails): ?> | |||
| <div class="open-link"><a href="<?=$url['url'] ?>" target="_blank" rel="nofollow" download><?=$this->icon('download')?> <?=$this->transEsc('Download video') ?></a></div> | |||
There was a problem hiding this comment.
Ei kait latauslinkkiä tarvitse avata uuteen välilehteen? Ottaisin pois target="_blank". (sama myös äänitiedostoihin)
|
Poistin review-pyynnön, kunnes on paremmassa tilassa. |
…her resource links.
pasitiis
reviewed
Dec 10, 2024
local/languages/finna/fi.ini
Outdated
| @@ -1072,6 +1074,7 @@ Show As Grid = "Kuvagalleria" | |||
| Show As List = "Tiedot ja kuvat" | |||
| Show Holdings = "Näytä saatavuustiedot" | |||
| Show Image Information = "Näytä kuvan tiedot" | |||
| Show information = "Näytä tiedot" | |||
There was a problem hiding this comment.
Laittaisin "Näytä videon tiedot" / Näytä äänitteen tiedot" koska kuvissa käytetty "Näytä kuvan tiedot", tuntuisi hassulta että videoissa/äänitteissä on pelkästään "Näytä tiedot". (omat käännösavaimet videolle ja äänitteelle)
Toinen vaihtoehto olisi että kaikissa aineistossa olisi "Näytä tiedot".
pasitiis
approved these changes
Dec 10, 2024
EreMaijala
requested changes
Dec 11, 2024
EreMaijala
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.