Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINNA-2446] Unify hierarchy term usage #3045

Merged
merged 20 commits into from
Dec 20, 2024
Merged

[FINNA-2446] Unify hierarchy term usage #3045

merged 20 commits into from
Dec 20, 2024

Conversation

siiriylonen
Copy link

No description provided.

@siiriylonen siiriylonen changed the title [FINNA-2446] Unify hierarchy tab names [FINNA-2446] Unify hierarchy term usage Dec 13, 2024
LuomaJuha
LuomaJuha reviewed Dec 16, 2024
View reviewed changes
Copy link

@LuomaJuha LuomaJuha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuli pari sivuhuomiota tuolta slackissa kysytystä kysymyksestä.

module/Finna/src/Finna/RecordTab/CollectionHierarchyTree.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordTab/HierarchyTree.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordTab/CollectionList.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordTab/CollectionList.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordDriver/SolrEad3.php Outdated Show resolved Hide resolved
themes/finna2/templates/Recommend/CollectionSideFacets.phtml Outdated Show resolved Hide resolved
themes/finna2/templates/RecordDriver/DefaultRecord/collection-record.phtml Outdated Show resolved Hide resolved
@siiriylonen siiriylonen marked this pull request as ready for review December 20, 2024 05:35
EreMaijala
EreMaijala requested changes Dec 20, 2024
View reviewed changes
Copy link

@EreMaijala EreMaijala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result-condensed:n kommentit koskevat myös result-list:iä. Olennaista noissa toiveissa olisi, että muuttujalla, jos sitä ylipäänsä tarvitaan, on kuvaava nimi.

module/Finna/src/Finna/RecordTab/CollectionList.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordTab/HierarchyTree.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/View/Helper/Root/RecordDataFormatterFactory.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/View/Helper/Root/RecordDataFormatterFactory.php Show resolved Hide resolved
themes/finna2/templates/RecordDriver/DefaultRecord/collection-record.phtml Outdated Show resolved Hide resolved
themes/finna2/templates/RecordDriver/DefaultRecord/result-compact.phtml Outdated Show resolved Hide resolved
themes/finna2/templates/RecordDriver/SolrEad/result-condensed.phtml Outdated Show resolved Hide resolved
themes/finna2/templates/RecordDriver/SolrEad/result-condensed.phtml Outdated Show resolved Hide resolved
themes/finna2/templates/RecordDriver/SolrEad/result-condensed.phtml Outdated Show resolved Hide resolved
@EreMaijala EreMaijala merged commit abf6755 into NatLibFi:dev Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuomaJuha LuomaJuha LuomaJuha left review comments

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siiriylonen @EreMaijala @LuomaJuha