forked from vufind-org/vufind
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINNA-2767] Initial implementation of disec support for reservation lists #3091
Merged
EreMaijala
merged 29 commits into
NatLibFi:dev
from
LuomaJuha:reservationlist-disec-implementation
Jan 15, 2025
Merged
[FINNA-2767] Initial implementation of disec support for reservation lists #3091
EreMaijala
merged 29 commits into
NatLibFi:dev
from
LuomaJuha:reservationlist-disec-implementation
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Dec 4, 2024
module/Finna/src/Finna/Controller/ReservationListController.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/ReservationList/ReservationListStatus.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/ReservationList/ReservationListStatus.php
Outdated
Show resolved
Hide resolved
EreMaijala
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Status-teksteistä vielä sen verran, että jos käyttäjän pitäisi niiden perusteella osata jotenkin toimia tai olla toimimatta, niin ei ole välttämättä mitenkään liian selkeä. Tarkoittaako esim. "processed", että aineisto on matkalla käyttäjälle, vai jotain muuta? Entä "Aineisto poistettu"?
- Laita kaikkiin
PHP version 8.1
=>PHP version 8
. Niin se on muuallakin. - Kaikki Connection:iin liittyvä pitäisi olla vielä omassa nimiavaruudessa, esim.
Finna\ReservationList\Connection
.
module/Finna/src/Finna/ReservationList/ReservationListService.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/ReservationList/ReservationListService.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/Controller/ReservationListController.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/Controller/ReservationListController.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/Controller/ReservationListController.php
Outdated
Show resolved
Hide resolved
EreMaijala
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juhan kanssa keskusteltu. Täytyy vielä muokata toimintatapaa, jotta saadaan tarvittaessa kaikille määriteltyä omat lähetystavat oikein ja selkeästi.
EreMaijala
requested changes
Jan 15, 2025
module/Finna/src/Finna/ReservationList/ReservationListService.php
Outdated
Show resolved
Hide resolved
EreMaijala
requested changes
Jan 15, 2025
module/Finna/src/Finna/ReservationList/ReservationListService.php
Outdated
Show resolved
Hide resolved
module/Finna/src/Finna/ReservationList/ReservationListService.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Ere Maijala <[email protected]>
Co-authored-by: Ere Maijala <[email protected]>
EreMaijala
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALTER TABLE finna_resource_list ADD COLUMN external_id varchar(255) DEFAULT NULL;
ALTER TABLE finna_resource_list MODIFY connection varchar(40) NOT NULL DEFAULT 'email';