[FINNA-2373] Fix search filters on smaller screens for sr #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasitiis
reviewed
Jan 15, 2025
themes/finna2/js/finna-layout.js
Outdated
| * Check and keep focus within the search facet list | ||
| * @param {object} e Event object | ||
| */ | ||
| function onFocusOut(e) { |
pasitiis
reviewed
Jan 24, 2025
| @@ -26,7 +26,10 @@ | |||
| $extraUrlFields = $results->getUrlQuery()->getParamsWithConfiguredDefaults(); | |||
| ?> | |||
| <div class="side-facets-container-ajax" data-search-class-id="<?=$this->escapeHtmlAttr($this->searchClassId) ?>" data-location="<?=$this->escapeHtmlAttr($this->location) ?>" data-config-index="<?=$this->escapeHtmlAttr($this->configIndex)?>" data-query="<?=$this->escapeHtmlAttr($urlQuery)?>" data-query-suppressed="<?=$querySuppressed ? '1' : '0' ?>" data-extra-fields="<?=$this->escapeHtml(implode(',', $extraUrlFields))?>"> | |||
| <h1><?=$this->transEsc($this->slot('side-facet-caption')->get('Narrow Search')) ?><?php if (null === $this->slot('side-facet-caption')->get() && !$this->translationEmpty('tooltip_facet_html')): ?><span class="tooltip-facet pull-right" data-toggle="tooltip" data-placement="auto" data-html="true" data-original-title="<?=$this->transEsc('tooltip_facet_html')?>"><?=$this->icon('help') ?></span><?php endif; ?><span role="button" class="visible-xs sidebar-close-btn" aria-label="<?=$this->transEsc('close')?>"><?=$this->icon('sidefacets-close', 'sidefacets-close-icon') ?></span></h1><?php endif; ?> | |||
| <div class="header-container"> | |||
There was a problem hiding this comment.
Pitäsikö luokan nimi olla side-facets-header-container tms.? Nyt ehkä vähän liian geneerinen.
EreMaijala
requested changes
Feb 11, 2025
themes/finna2/js/finna-layout.js
Outdated
| */ | ||
| function onSidebarBtnClick() { | ||
| $('.sidebar').toggleClass('open'); | ||
| $('.mobile-navigation .sidebar-navigation i').toggleClass('fa-arrow-down'); |
There was a problem hiding this comment.
Ei ikonin luokkaa kovakoodattuna. Jos pitää JS:ssä vaihtaa ikonia, niin pitää laittaa templaatissa kaksi ikonia, joita vaihdellaan.
| $('.mobile-navigation .sidebar-navigation, .sidebar .mylist-bar h1').off('click').on('click', function onClickMobileNav() { | ||
| onSidebarBtnClick(); | ||
| }); | ||
| const container = document.querySelector(".side-facets-container-ajax"); |
There was a problem hiding this comment.
Pitää tarkistaa, löytyikö container (tyyliin if (!container) { return; }).
| width: 100%; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| background-color: $brand-primary; |
| padding: 0; | ||
| } | ||
| button { | ||
| background-color: $brand-primary; |
…ot full width in favourites list on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.