[FINNA-2579] & [FINNA-2875] Add file size to LIDO resource and fix resource play buttons for sr #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms with resource links and player.
EreMaijala
requested changes
Jan 28, 2025
| * | ||
| * @return array | ||
| */ | ||
| protected function getModel( | ||
| string $url, | ||
| string $format, | ||
| string $type, | ||
| \SimpleXmlElement $measurements = null, |
There was a problem hiding this comment.
Tämän tyypin pitäisi olla ?\SimpleXmlElement
| * | ||
| * @return array | ||
| */ | ||
| protected function getAudio( | ||
| string $url, | ||
| string $format, | ||
| string $description | ||
| string $description, | ||
| \SimpleXmlElement $measurements = null |
There was a problem hiding this comment.
Tämän tyypin pitäisi olla ?\SimpleXmlElement
| @@ -923,6 +951,9 @@ protected function getAudio( | |||
| 'codec' => $format, | |||
| 'type' => 'audio', | |||
| 'embed' => 'audio', | |||
| 'data' => $this->formatResourceMeasurements( | |||
There was a problem hiding this comment.
Ei voi kutsua formatResourceMeasurements-metodia varmistamatta, ettei $measurements ole null.
| @@ -955,6 +988,9 @@ protected function getVideo( | |||
| 'url' => $url, | |||
| 'embed' => 'iframe', | |||
| 'format' => $format, | |||
| 'data' => $this->formatResourceMeasurements( | |||
There was a problem hiding this comment.
Ei voi kutsua formatResourceMeasurements-metodia varmistamatta, ettei $measurements ole null.
| @@ -966,6 +1002,9 @@ protected function getVideo( | |||
| 'src' => $url, | |||
| 'type' => $mediaType, | |||
| ], | |||
| 'data' => $this->formatResourceMeasurements( | |||
There was a problem hiding this comment.
Ei voi kutsua formatResourceMeasurements-metodia varmistamatta, ettei $measurements ole null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.