Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BT1886 view EOTF #928

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add BT1886 view EOTF #928

merged 2 commits into from
Nov 28, 2023

Conversation

cedricp
Copy link
Contributor

@cedricp cedricp commented Oct 12, 2023

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Add BT1886 display EOTF

Have you tested your changes (if applicable)? If so, how?

Yes, by comparing with other software (Nuke)

Futher details of this pull request

I added this EOTF because it was missing. BT1886 is the correct monitor "gamma" for Rec2020/Rec709 HDTV.
I discovered that the Rec709 EOTF used in Natron is the one for camera linear to non-linear signal, so it seems a bit useless to me.

Here is a note about it in wikipedia :

Rec. 709 specifies a non-linear OETF (opto-electrical transfer function) which is known as the "camera gamma" and which describes how HDTV camera encodes the linear scene light into a non-linear electrical signal value. Rec. 709 doesn't specify the display EOTF (electro-optical transfer function) which describes how HDTV displays should convert the non-linear electrical signal into linear displayed light, that was done in ITU-R BT.1886. Rec.709 is "scene-referred", which means that change of primaries should happen on scene linear light (by applying inverse OETF, changing primaries and applying OETF again, only after which you convert to display linear light using EOTF).

Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

@devernay devernay merged commit e81c3f3 into NatronGitHub:RB-2.5 Nov 28, 2023
2 checks passed
@redesaimig
Copy link

quiero salir y no recibir mas email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants