Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Add BT1886 display EOTF
Have you tested your changes (if applicable)? If so, how?
Yes, by comparing with other software (Nuke)
Futher details of this pull request
I added this EOTF because it was missing. BT1886 is the correct monitor "gamma" for Rec2020/Rec709 HDTV.
I discovered that the Rec709 EOTF used in Natron is the one for camera linear to non-linear signal, so it seems a bit useless to me.
Here is a note about it in wikipedia :
Rec. 709 specifies a non-linear OETF (opto-electrical transfer function) which is known as the "camera gamma" and which describes how HDTV camera encodes the linear scene light into a non-linear electrical signal value. Rec. 709 doesn't specify the display EOTF (electro-optical transfer function) which describes how HDTV displays should convert the non-linear electrical signal into linear displayed light, that was done in ITU-R BT.1886. Rec.709 is "scene-referred", which means that change of primaries should happen on scene linear light (by applying inverse OETF, changing primaries and applying OETF again, only after which you convert to display linear light using EOTF).