feat: add increment to CommonKeyValueDao

src/kv/commonKeyValueDao.ts

@@ -252,4 +252,8 @@ export class CommonKeyValueDao<T> {
       },
     )
   }
+
+  async increment(id: string, by = 1): Promise<number> {
+    return await this.cfg.db.increment(this.cfg.table, id, by)
+  }
 }

src/testing/hashKeyValueDBTest.ts

@@ -13,6 +13,11 @@ export function runCommonHashKeyValueDBTest(db: CommonKeyValueDB): void {
     await db.deleteByIds(TEST_TABLE, ids)
   })
 
+  afterAll(async () => {
+    const ids = await db.streamIds(TEST_TABLE).toArray()
+    await db.deleteByIds(TEST_TABLE, ids)
+  })
+
   runCommonKeyValueDBTest(db)
 
   test('increment on a non-existing field should set the value to 1', async () => {

src/testing/hashKeyValueDaoTest.ts

@@ -0,0 +1,35 @@
+import { CommonKeyValueDao } from '../kv/commonKeyValueDao'
+import { runCommonKeyValueDaoTest } from './keyValueDaoTest'
+
+export function runCommonHashKeyValueDaoTest(dao: CommonKeyValueDao<Buffer>): void {
+  beforeAll(async () => {
+    // Tests in this suite are not isolated,
+    // and failing tests can leave the DB in an unexpected state for other tests,
+    // including the following test run.
+    // Here we clear the table before running the tests.
+    const ids = await dao.streamIds().toArray()
+    await dao.deleteByIds(ids)
+  })
+
+  afterAll(async () => {
+    const ids = await dao.streamIds().toArray()
+    await dao.deleteByIds(ids)
+  })
+
+  runCommonKeyValueDaoTest(dao)
+
+  test('increment on a non-existing field should set the value to 1', async () => {
+    const result = await dao.increment('nonExistingField')
+    expect(result).toBe(1)
+  })
+
+  test('increment on a existing field should increase the value by one', async () => {
+    const result = await dao.increment('nonExistingField')
+    expect(result).toBe(2)
+  })
+
+  test('increment should increase the value by the specified amount', async () => {
+    const result = await dao.increment('nonExistingField', 2)
+    expect(result).toBe(4)
+  })
+}

src/testing/index.ts

@@ -1,5 +1,6 @@
 import { runCommonDaoTest } from './daoTest'
 import { CommonDBImplementationQuirks, runCommonDBTest } from './dbTest'
+import { runCommonHashKeyValueDaoTest } from './hashKeyValueDaoTest'
 import { runCommonHashKeyValueDBTest } from './hashKeyValueDBTest'
 import { runCommonKeyValueDBTest } from './keyValueDBTest'
 import {
@@ -25,6 +26,7 @@ export {
   createTestItemsDBM,
   runCommonDaoTest,
   runCommonDBTest,
+  runCommonHashKeyValueDaoTest,
   runCommonHashKeyValueDBTest,
   runCommonKeyValueDBTest,
   TEST_TABLE,