Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin/prevent-default-import에서 jsx 문법도 지원 #48

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

byhhh2
Copy link
Contributor

@byhhh2 byhhh2 commented Jul 10, 2024

Related Issue

#41

Describe your changes

- import React from 'react'
+ import {StrictMode} from 'react'

const Component = () => {
-  return <React.StrictMode />
+  return <StrictMode />
}
  • jsx 문법도 지원합니다.
  • typescript/prevent-default-import rule을 deprecated하고 prevent-default-import로 사용하도록 수정했습니다.
    • prevent-default-import가 js, ts, jsx 지원

@byhhh2 byhhh2 added the plugin label Jul 10, 2024
@byhhh2 byhhh2 self-assigned this Jul 10, 2024
@byhhh2 byhhh2 requested a review from a team as a code owner July 10, 2024 09:32
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: d8d1dc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@naverpay/eslint-plugin Minor
@naverpay/eslint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@byhhh2
Copy link
Contributor Author

byhhh2 commented Jul 10, 2024

canary

@byhhh2 byhhh2 linked an issue Jul 10, 2024 that may be closed by this pull request
yceffort-naver
yceffort-naver previously approved these changes Jul 10, 2024
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

2-one-week
2-one-week previously approved these changes Jul 10, 2024
Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

boxersb
boxersb previously approved these changes Jul 12, 2024
Copy link

@boxersb boxersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised-surprise

@boxersb
Copy link

boxersb commented Jul 12, 2024

에구.. 컨플릭이 있네용..

@byhhh2 byhhh2 dismissed stale reviews from boxersb, 2-one-week, and yceffort-naver via d8d1dc3 July 15, 2024 09:18
@byhhh2
Copy link
Contributor Author

byhhh2 commented Jul 15, 2024

@boxersb 님, @yceffort-naver 님, @2-one-week
lock 파일에 충돌이 있어서 해결 후 push 했는데 확인 요청 드립니당 🙇🏻‍♀️

Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@byhhh2 byhhh2 merged commit 9fc578a into main Jul 15, 2024
2 checks passed
@byhhh2 byhhh2 deleted the feat/41 branch July 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevent-default-import rule을 jsx 문법에서 지원
4 participants