Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5] @naverpay/markdown-lint 패키지를 추가합니다 #6

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

geonmo-nine
Copy link
Contributor

@geonmo-nine geonmo-nine commented Mar 27, 2024

Related Issue

Request

  • root 패키지에서 workspace 를 참조하도록 합니다.
  • markdown-lint 은 rollup을 통한 번들링하지 않고, 단순하게 제공하도록 변경했습니다. ( @byhhh2 님, 의견이 다르시다면 말씀부탁드려요!)

@geonmo-nine geonmo-nine self-assigned this Mar 27, 2024
@geonmo-nine geonmo-nine requested a review from a team as a code owner March 27, 2024 06:20
Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: 0647588

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고고고~

Copy link
Contributor

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 확인이 늦었습니다 ㅠ
감사합니다!

Comment on lines +1 to +28
#!/usr/bin/env node
const {execSync} = require('child_process')
const fs = require('fs')
const path = require('path')

const createConfigFile = (dirname, fileName, destFileName = fileName) => {
try {
const source = path.join(dirname, fileName)
const config = fs.readFileSync(source)

const gitRoot = execSync('git rev-parse --show-toplevel').toString().trim()
const dest = path.join(gitRoot, destFileName)

if (fs.existsSync(dest)) {
process.exit(0)
}
fs.writeFileSync(dest, config)
console.log(`${destFileName} is created successfully`)
} catch (error) {
console.log(`Failed to create ${destFileName}`)
console.log(error?.message)
process.exit(0)
}
}

module.exports = {
createConfigFile,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기로 옮겨갔군요!
이견 없습니다~

@geonmo-nine geonmo-nine merged commit b453e30 into main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants