Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 add eslint-plugin-package-json plugin for default setting #85

Merged
merged 2 commits into from
Feb 19, 2025
Merged

📦 add eslint-plugin-package-json plugin for default setting #85

merged 2 commits into from
Feb 19, 2025

Conversation

yceffort-naver
Copy link
Contributor

Related Issue

#83

Describe your changes

  • add eslint-plugin-package-json plugin

@yceffort-naver yceffort-naver requested a review from a team as a code owner February 18, 2025 02:13
@yceffort-naver yceffort-naver self-assigned this Feb 18, 2025
@npayfebot
Copy link
Contributor

npayfebot commented Feb 18, 2025 •
edited
Loading

✅ Changeset detected

Latest commit: 230bb8f

@naverpay/eslint-config package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

keemhyunseok
keemhyunseok approved these changes Feb 19, 2025
View reviewed changes
Copy link

@keemhyunseok keemhyunseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

2-one-week
2-one-week approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

byhhh2
byhhh2 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L
G
T
M

@yceffort-naver
Copy link
Contributor Author

감사연!

@yceffort-naver yceffort-naver merged commit 442dbfc into main Feb 19, 2025
3 checks passed
@yceffort-naver yceffort-naver deleted the feature/83 branch February 19, 2025 06:43
@npayfebot npayfebot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byhhh2 byhhh2 byhhh2 approved these changes

@2-one-week 2-one-week 2-one-week approved these changes

@keemhyunseok keemhyunseok keemhyunseok approved these changes

@yongholeeme yongholeeme Awaiting requested review from yongholeeme

Assignees

@yceffort-naver yceffort-naver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yceffort-naver @npayfebot @byhhh2 @2-one-week @keemhyunseok