refactor: made solana methods to support event as an input #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frolvanya
changed the title
I had a bug with `sign_transfer` method if it returned timeout, sdk returned `UnknownError` and it's impossible to differintiate between real error and timeout
frolvanya
force-pushed
the
refactor/solana-bridge-client
branch
from
de9986d to
77e0120
Compare
kiseln
reviewed
Dec 17, 2024
bridge-sdk/bridge-clients/solana-bridge-client/src/solana_bridge_client.rs
Outdated
Show resolved
Hide resolved
* Solana: fix finalize transfer * chore: removed `unwrap` * fix: `get_native_token_id` method arguments * Fix determining native/bridged * fix: applied same logic with vault/program_id to `finalize_transfer` method * fix: used standard method `storage_balance_bounds` --------- Co-authored-by: Ivan Frolov <[email protected]>
kiseln
reviewed
Dec 19, 2024
`RpcBroadcastTxAsyncRequest` which is used in `change` method always immediately returns a transaction hash and it's to avoid an extra check on relayer's side I rewrote all methods to wait until any transaction status
kiseln
approved these changes
Jan 9, 2025
kiseln
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very incovenient to use these methods by sending tx_hash as a input arguments, so let's support event as an argument as well (just like we did with evm methods)