Solana: fix finalize transfer #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frolvanya
requested changes
Dec 17, 2024
bridge-sdk/bridge-clients/solana-bridge-client/src/solana_bridge_client.rs
Outdated
Show resolved
Hide resolved
|
Also, let's merge it to my PR first. I'll fix it right now, feel free to revert any changes |
frolvanya
changed the base branch from
main
to
refactor/solana-bridge-client
frolvanya
force-pushed
the
solana-fxies
branch
from
6660cb2 to
c20d9a5
Compare
frolvanya
approved these changes
Dec 17, 2024
frolvanya
merged commit c1e8149
into
refactor/solana-bridge-client
1 of 5 checks passed
frolvanya
added a commit
that referenced
this pull request
Jan 9, 2025
* refactor: splitted solana methods to support sending tx by tx_hash or given event * feat: made near bridge return only tx hash as a result I had a bug with `sign_transfer` method if it returned timeout, sdk returned `UnknownError` and it's impossible to differintiate between real error and timeout * Solana: fix finalize transfer (#60) * Solana: fix finalize transfer * chore: removed `unwrap` * fix: `get_native_token_id` method arguments * Fix determining native/bridged * fix: applied same logic with vault/program_id to `finalize_transfer` method * fix: used standard method `storage_balance_bounds` --------- Co-authored-by: Ivan Frolov <[email protected]> * fix: moved `solana_..._with_event` methods to omni-connector * fix: check balance of token instead of locker * fix: use `total` attribute while checking storage balance * feat: decided which `finalize_transfer` to call based on token addr * fix: created a new instruction for finalize_transfer_sol method * fix: near sign transfer * fix: wait until unknown status (#61) `RpcBroadcastTxAsyncRequest` which is used in `change` method always immediately returns a transaction hash and it's to avoid an extra check on relayer's side I rewrote all methods to wait until any transaction status * chore: removed unused deps * fix: changed `deploy_token` gas/deposit consts after merging --------- Co-authored-by: kiseln <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Near token id as it's not needed.
Determine whether token is native or bridged by looking at mint_authority