feat: added gas estimation for EVM transactions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiseln
reviewed
Jan 15, 2025
| client | ||
| .estimate_gas(&call.tx, None) | ||
| .await | ||
| .map_err(|err| BridgeSdkError::EvmGasEstimateError(err.to_string()))?; |
There was a problem hiding this comment.
Wouldn't this be EthRpcError?
There was a problem hiding this comment.
I want to be able to differentiate in the future between rpc error (e.g rever or network issue) and gas estimation
There was a problem hiding this comment.
Isn't gas estimation also a network call?
There was a problem hiding this comment.
@frolvanya How do you differ between network error and estimated gas error
There was a problem hiding this comment.
That's a good question. Probably I could look inside ProviderError and if it's HTTPError(_) I can return BridgeSdkError::NetworkError
On the second thought. Do we really care if it's gas estimation or network issue? I mean both of these errors could indicate that we need to retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.