test: add integration tests for Ownable plugin
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Jan 10, 2023
| /// it. | ||
| /// | ||
| /// It is possible to use `#[only(self)]` even if the contract does not derive `Ownable`. | ||
| #[only(self)] |
There was a problem hiding this comment.
Is only(self) equivilent to private from near-sdk?
There was a problem hiding this comment.
True, they are equivalent. I think we should mention that in the docs and recommend using #[private] rather than #[only(self)], since the latter is provided by near-sdk directly. Would that make sense?
I’ve merged this PR since it’s intended to be a port of unit to integration tests. In a follow-up PR I can handle the self docs, if necessary.
mrLSD
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests for
Ownableand removes the corresponding unit tests. The background and motivation are described in #51, which does the same forPausable.