fix: normalize transferred tokens by decimals #159
Conversation
karim-en
force-pushed
the
normalise-decimals
branch
from
862fe16 to
2e8df29
Compare
|
Can we avoid usign near and do normalization/denormalization purely on destination chains? For example, when we deploy on a destination chain we store original decimals and if it's higher than the threshold value we do transformations on each init/finalize |
We can, but more changes will be needed + we will have a problem with the dust remainder which affect the total supply. |
I understand the dust issue but otherwise I see my suggested approach to be way simpler unless I'm missing something |
Actually, I've tried to implement it like that, and found that is implementation become too complex, so I moved all this logic just to Near side. |
|
@karim-en Just in case, while the changes are approved, please, pay attention to the fact that EVM tests failed and the Rust build failed as well. |
| let destination_nonce = | ||
| self.get_next_destination_nonce(init_transfer.recipient.get_chain()); | ||
| let transfer_message = TransferMessage { | ||
| origin_nonce: init_transfer.origin_nonce, | ||
| token: init_transfer.token, | ||
| amount: init_transfer.amount, | ||
| amount: Self::de_normalize_amount(init_transfer.amount.0, decimals).into(), | ||
| recipient: init_transfer.recipient, |
There was a problem hiding this comment.
denormalize would be one word
| @@ -44,7 +44,8 @@ library BridgeTypes { | |||
| string token, | |||
| string name, | |||
| string symbol, | |||
| uint8 decimals | |||
| uint8 decimals, | |||
| uint8 originDecimals | |||
There was a problem hiding this comment.
Do we need originDecimals? Since we have token we can look it up on Near
There was a problem hiding this comment.
It is a little bit complicated to retrieve the origin decimals due to async specific of the cross calls on Near, so by adding this we can reduce the number of callbacks on Near side
| @@ -86,6 +88,8 @@ impl<'info> DeployToken<'info> { | |||
| let payload = DeployTokenResponse { | |||
| token: metadata.token, | |||
| solana_mint: self.mint.key(), | |||
| decimals: metadata.decimals, | |||
| origin_decimals, | |||
Problem:
On Solana, the max normal decimal of the SPL token is
9and theu64is used for the transferred token amount, but on the Near side, the tokens usually have24decimals which prevents us from bridging this kind of tokens.Solition:
18on EVM and9Solana.