Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't burn the fee on ft_on_transfer #168

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix: don't burn the fee on ft_on_transfer #168

merged 2 commits into from
Dec 26, 2024

Conversation

olga24912
Copy link
Contributor

Issue: #165

@olga24912 olga24912 mentioned this pull request Dec 25, 2024
Closed
@karim-en
Copy link
Collaborator

@olga24912 but what if the fee is updated?

@karim-en
Copy link
Collaborator

@olga24912 but what if the fee is updated?

I propose to burn everything and then mint on the claiming fee.

@olga24912
Copy link
Contributor Author

@olga24912 but what if the fee is updated?

I propose to burn everything and then mint on the claiming fee.

fixed: dbf920e

@kiseln
Copy link
Contributor

kiseln commented Dec 26, 2024

@olga24912 but what if the fee is updated?

I propose to burn everything and then mint on the claiming fee.

Agree this is better. Plus, I think this is the only way for transfers between 2 non-near chains

@karim-en karim-en merged commit 3bf06d5 into main Dec 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frolvanya frolvanya frolvanya approved these changes

@karim-en karim-en karim-en approved these changes

@kiseln kiseln kiseln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olga24912 @karim-en @kiseln @frolvanya