Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatible address prefix for ETH network #176

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented Jan 6, 2025

The Rainbow Bridge deploys tokens in this format <lower_case_hex>.factory.bridge.near, after the migration we are going to use factory.bridge.near as deployer and the tokens for ethereum chain will be deployed in the same format.

Copy link
Contributor

@olga24912 olga24912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to verify that the addresses are formatted correctly? I’m not entirely sure what address.to_string() will return—it might include a prefix like 0x

@karim-en
Copy link
Collaborator Author

karim-en commented Jan 7, 2025

Can you add a test to verify that the addresses are formatted correctly? I’m not entirely sure what address.to_string() will return—it might include a prefix like 0x

@olga24912 fixed in bb67ce4

@karim-en karim-en merged commit d5d365a into main Jan 8, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants