-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added mpc getter and updated near-plugins #183
Conversation
rustc 1.79.0 is not supported by the alloy crates
near/omni-bridge/src/lib.rs
Outdated
@@ -394,6 +394,9 @@ impl Contract { | |||
fee: &Option<Fee>, | |||
) -> Promise { | |||
let transfer_message = self.get_transfer_message(transfer_id); | |||
|
|||
require!(transfer_message.amount.0 > 0, "Invalid amount"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should be done for the normalised amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 704963c
rustc 1.79.0 is not supported by the alloy crates
cargo clippy had warning here
rustc 1.79.0 is not supported by the alloy crates
rustc v1.82.0+ has some issues with wasm. Source: https://near.zulipchat.com/#narrow/channel/295302-general/topic/default.20wasm.20features.20in.20Rust.20.28.2Bmultivalue.2C.2Breference-types.29/near/475780216
What's the motivation for MPC getter? |
To get required deposit for |
Also, one more thing to add, as you can see there's an issue with rustc version + lib versioning + wasm, since you need to optimize wasm after rustc v1.82.0 and we can't just use 1.81.0 or 1.79.0 since we upgraded near-plugins. I was able to compile wasm with 1.84.0 or run tests. During compilation I used
Pros of
Cons:
|
No description provided.