feat: track deploy_token calls to bind token
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-transfer-changes
frolvanya
changed the base branch from
feat/reflect-near-fin-transfer-changes
to
main
olga24912
approved these changes
Jan 29, 2025
omni-relayer/src/workers/near.rs
Outdated
| ) | ||
| .await; | ||
|
|
||
| if vaa.is_none() { |
There was a problem hiding this comment.
This part looks similar to a section of the claim_fee function. Maybe the common code can be extracted?
There was a problem hiding this comment.
I've splitted core methods into handle_{chain}_fin_transfer and handle_{chain}_deploy_token_event in b66fac6. Technically I could extract this, but IMO after doing such refactor it would be harder to follow the logic. Let me know if you think that it's worth to extract it even more
| }, | ||
| } | ||
|
|
||
| pub async fn bind_token( |
There was a problem hiding this comment.
Can we split this function on a few parts? For example handle_evm_bind_tokens and handle_solana_bind_tokens. This function turned out to be very long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #207