-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Near -> Eth connectors #99
Conversation
added tests for BridgeToken lack of tests for BridgeTokenFactory - will be added in next commits
…n/rainbow-token-connector into near-eth-connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing such useful things, guys!
Added some comments that need to be addressed as per the initial review. In general, looks good!
Co-authored-by: Kirill <[email protected]>
I didn't update to near-plugins because versions of dependencies don't match. I suggest to do that in a separate PR otherwise, this going to be a huge mess as it needs all changes from #96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good security wise.
Last update - I cut some errors just to get some space. Is it ok? |
Co-authored-by: Kirill <[email protected]>
Co-authored-by: Kirill <[email protected]>
No, please revert. |
This reverts commit 5a77538.
Reverted |
e4b3ee6
to
2496b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging it now. All future improvements should be done in separate PRs.
Two new connectors are added:
token-factory
- locks NEP141 tokens on NEAR side and emits<token, amount, recipient address>
. AcceptsUnlock
event from Ethereum side, verifies it's correctness and releases funds to it.erc20-bridge-token
-BridgeTokenFactory
andBridgeToken
Ethereum contracts.BridgeTokenFactory
creates newBridgeToken
that correspond to specific token account id on NEAR side.BridgeTokenFactory
can receive events from NEAR, verify them and mint appropriate amounts on recipient addresses. Callingwithdraw
will burn tokens of this user and will generate event<>
that can be relayed totoken-factory
.