Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adds a unitless percent unit #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CrownedPhoenix
Copy link

Adds support for a percent unit type.

Some review will be needed to make sure I've tested everything worth testing in this regard.
So far, everything seems to 'just work'.

@bjschoenfeld
Copy link

Looks good to me!

Copy link
Owner

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jairon! Glad to see it #justworks

Sources/Units/Unit/DefaultUnits.swift Show resolved Hide resolved
@@ -196,6 +196,64 @@ final class MeasurementTests: XCTestCase {
)
}

func testPercent() throws {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an additional test in the DefinitionsTests.swift and copy the formatting there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that file?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants