-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Adds a unitless percent
unit
#15
base: main
Are you sure you want to change the base?
feature: Adds a unitless percent
unit
#15
Conversation
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jairon! Glad to see it #justworks
@@ -196,6 +196,64 @@ final class MeasurementTests: XCTestCase { | |||
) | |||
} | |||
|
|||
func testPercent() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an additional test in the DefinitionsTests.swift
and copy the formatting there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops - my bad. I meant DefinitionTests.swift
:
https://github.com/NeedleInAJayStack/Units/blob/main/Tests/UnitsTests/DefinitionTests.swift
de8256c
to
21f7aa4
Compare
Adds support for a
percent
unit type.Some review will be needed to make sure I've tested everything worth testing in this regard.
So far, everything seems to 'just work'.