Fixed 404 on /random, edited the router system a bit for simplicity, …

…hid the error message for security

src/index.js

@@ -48,6 +48,23 @@ const main = async () => {
     const routes = fs.readdirSync(path.join(__dirname, 'routes')).filter(file => file.endsWith('.js'));
     for (const file of routes) {
         const route = require(`./routes/${file}`);
+
+        if (Array.isArray(route)) {
+            for (const r of route) {
+                if(r.path && isValidMethod(r.method)) {
+                    // this code is old, too lazy to rewrite it to use a better router system. Like they say, Don't Touch If It Works!
+                    const run = (req, res) => {
+                        // conditions before run here
+
+                        return r.router(req, res, logger, {});
+                    };
+                    app[r.method.toLowerCase()](r.path, run);
+                    logger.info(`Loaded route ${r.path} (${r.method.toUpperCase()})`, 'Express');
+                }
+            }
+            continue;
+        }
+
         if(route.path && isValidMethod(route.method)) {
             const run = (req, res) => {
                 // conditions before run here

src/routes/random.js

@@ -1,17 +1,25 @@
 const express = require('express');
 
+module.exports = [
+    {
+        path: "/random/:type",
+        method: "get",
+        router: (req, res, data, logger) => {
+            const type = req.params.type;
+            if (!type) return res.redirect('/random/neko');
+            if (!['neko', 'kitsune', 'lewd', 'hug', 'kiss', 'pat', 'slap'].includes(type)) return res.redirect('/random/neko');
 
-module.exports = {
-    path: "/random/:type",
-    method: "get",
-    router: (req, res, data, logger) => {
-        const type = req.params.type;
-        if (!type) return res.status(400).json({ message: 'Bad request.' });
-        if (!['neko', 'kitsune', 'lewd', 'hug', 'kiss', 'pat', 'slap'].includes(type)) return res.redirect('/random/neko');
-
-        return res.render('random', {
-            page: req.url,
-            type: type
-        });
+            return res.render('random', {
+                page: req.url,
+                type: type
+            });
+        }
+    },
+    {
+        path: "/random",
+        method: "get",
+        router: (req, res) => {
+            return res.redirect('/random/neko');
+        }
     }
-};
+];

web/views/404.ejs

@@ -10,7 +10,7 @@
             <h1 class="display-1 fw-bold">404</h1>
             <p class="fs-3"> <span class="text-danger">Oops!</span> Page not found!</p>
             <p class="lead">
-                The requested content has not been found in this server.
+                The requested content has not been found on this server.
               </p>
             <a href="/" class="btn btn-primary">Go Home!</a>
         </div>

web/views/globalerror.ejs

@@ -10,8 +10,8 @@
             <h1 class="display-1 fw-bold"><%= status %></h1>
             <p class="fs-3"> <span class="text-danger">Oops!</span> An error occured!</p>
             <p class="lead">
-                <%= error.message %>
-              </p>
+                An error has occured while processing your request. Please try again later. If the problem persists, please contact the system administrator.
+            </p>
             <a href="/" class="btn btn-primary">Go Home!</a>
         </div>
     </div>