Update the charts by fixes issues and updating labels. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of 'SUM'; Removed the 'Top topFsx NetApp-FSx DataReadOperationTime' and the 'Top topFsx NetApp-FSx DataWriteOperationTime' charts because they didn't show average latency as people might think; Fixed the 'Total Client IOPS' and 'Disk Performance' charts by dividing all metrics by PERIOD; Normalized all the operations per seconds to be based on milliseconds, throughputs to be on MB/s and compacity to be based on GiB/s; Updated labels to be more accurate; Made all the values in the chart to only be at most 2 places behind the decimal point.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
LirazRom10
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Storage Used and Capacity Used charts by having them use 'AVG' instead of 'SUM'; Removed the 'Top topFsx NetApp-FSx DataReadOperationTime' and the 'Top topFsx NetApp-FSx DataWriteOperationTime' charts because they didn't show average latency as people might think; Fixed the 'Total Client IOPS' and 'Disk Performance' charts by dividing all metrics by PERIOD; Normalized all the operations per seconds to be based on milliseconds, throughputs to be on MB/s and compacity to be based on GiB/s; Updated labels to be more accurate; Made all the values in the chart to only be at most 2 places behind the decimal point.