Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed icmp rule and rt ids requirement #66

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fixed icmp rule and rt ids requirement #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc102ca
fixed icmp rule and rt ids requirement
Jan 29, 2024
2619f57
Merge branch 'main' of https://github.com/NetApp/FSxN-Samples into ke…
Jan 29, 2024
47de923
terraform-docs: automated action
github-actions[bot] Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Terraform/deploy-fsx-ontap/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ module "fsxontap" {
create_sg = <true / false> // true to create Security Group for the Fs / false otherwise
cidr_for_sg = "<YOUR-CIDR-BLOCK>"
fsx_admin_password = "<YOUR_PASSWORD>"
route_table_ids = [<"ID-1", "ID-2", ...>]
tags = {
Terraform = "true"
Environment = "dev"
Expand Down Expand Up @@ -196,7 +195,6 @@ terraform apply -y
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| fsx_admin_password | The ONTAP administrative password for the fsxadmin user that you can use to administer your file system using the ONTAP CLI and REST API | `string` | n/a | yes |
| route_table_ids | Specifies the VPC route tables in which your file system's endpoints will be created. You should specify all VPC route tables associated with the subnets in which your clients are located. | `list(any)` | n/a | yes |
| backup_retention_days | The number of days to retain automatic backups. Setting this to 0 disables automatic backups. You can retain automatic backups for a maximum of 90 days. | `number` | `0` | no |
| cidr_for_sg | cide block to be used for the ingress rules | `string` | `"0.0.0.0/0"` | no |
| create_sg | Determines whether the SG should be deployed as part of this execution or not | `bool` | `false` | no |
Expand All @@ -210,6 +208,7 @@ terraform apply -y
| fsx_tput_in_MBps | The throughput capacity (in MBps) for the file system. Valid values are 128, 256, 512, 1024, 2048, and 4096. | `number` | `256` | no |
| kms_key_id | ARN for the KMS Key to encrypt the file system at rest, Defaults to an AWS managed KMS Key. | `string` | `null` | no |
| root_vol_sec_style | Specifies the root volume security style, Valid values are UNIX, NTFS, and MIXED. All volumes created under this SVM will inherit the root security style unless the security style is specified on the volume. | `string` | `"UNIX"` | no |
| route_table_ids | Specifies the VPC route tables in which your file system's endpoints will be created. You should specify all VPC route tables associated with the subnets in which your clients are located. | `list(any)` | `null` | no |
| storage_type | The filesystem storage type | `string` | `"SSD"` | no |
| svm_name | The name of the Storage Virtual Machine | `string` | `"first_svm"` | no |
| tags | Tags to be applied to the resources | `map(any)` | <pre>{<br> "Name": "terraform-fsxn"<br>}</pre> | no |
Expand Down
2 changes: 2 additions & 0 deletions Terraform/deploy-fsx-ontap/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ resource "aws_vpc_security_group_ingress_rule" "all_icmp" {
security_group_id = aws_security_group.fsx_sg[count.index].id
description = "Allow all ICMP traffic"
cidr_ipv4 = "0.0.0.0/0"
from_port = -1
to_port = -1
ip_protocol = "icmp"
}

Expand Down
1 change: 1 addition & 0 deletions Terraform/deploy-fsx-ontap/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ variable "storage_type" {
variable "route_table_ids" {
description = "Specifies the VPC route tables in which your file system's endpoints will be created. You should specify all VPC route tables associated with the subnets in which your clients are located."
type = list(any)
default = null
}

variable "svm_name" {
Expand Down