feat: include start time, exported metrics, and poll duration in coll… #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ector logs feat: PollInstance and PollCounter should be logged with start time, api, and poll duration Examples: `2023-11-16T13:26:57-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=1574 begin=1700159216 collector=RestPerf:WAFLAggr metrics=23 pollMs=1580 task=counter` `2023-11-16T13:26:58-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=354 begin=1700159218 collector=RestPerf:NFSv42 instances=9 pollMs=354 task=instance` `2023-11-16T13:29:03-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=4152 begin=1700159336414 calcMs=0 collector=Rest:SecurityAccount exportMs=2 instances=39 instancesExported=266 metrics=193 metricsExported=1620 parseMs=0 pluginMs=3185 pollMs=7337`
Hardikl
approved these changes
Nov 17, 2023
rahulguptajss
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ector logs
feat: PollInstance and PollCounter should be logged with start time, api, and poll duration
Examples:
2023-11-16T13:26:57-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=1574 begin=1700159216 collector=RestPerf:WAFLAggr metrics=23 pollMs=1580 task=counter2023-11-16T13:26:58-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=354 begin=1700159218 collector=RestPerf:NFSv42 instances=9 pollMs=354 task=instance2023-11-16T13:29:03-05:00 INF collector/collector.go:567 > Collected Poller=sar apiMs=4152 begin=1700159336414 calcMs=0 collector=Rest:SecurityAccount exportMs=2 instances=39 instancesExported=266 metrics=193 metricsExported=1620 parseMs=0 pluginMs=3185 pollMs=7337Fixes: #1519