feat: add streaming to keyperf collector #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch_size : 1
Before:
time=2025-01-23T17:11:31.070+05:30 level=INFO source=collector.go:601 msg=Collected Poller=dc-1 collector=KeyPerf:Volume apiMs=114399 bytesRx=526288 calcMs=1 exportMs=3 instances=178 instancesExported=211 metrics=3382 metricsExported=2532 numCalls=365 numPartials=0 parseMs=65474 pluginInstances=33 pluginMs=1 pollMs=114420 renderedBytes=417499 skips=0 zBegin=1737632376646
After:
time=2025-01-23T16:36:21.714+05:30 level=INFO source=collector.go:601 msg=Collected Poller=dc-1 collector=KeyPerf:Volume apiMs=115401 bytesRx=526288 calcMs=1 exportMs=5 instances=178 instancesExported=211 metrics=3382 metricsExported=2532 numCalls=365 numPartials=0 parseMs=39 pluginInstances=33 pluginMs=2 pollMs=115408 renderedBytes=417482 skips=0 zBegin=1737630266300