return-netsuite-error-for-search-action-failures #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why Currently, if the `Search` action is unsuccessful, it will simply return `false` and give no insight into what the error was. Looking at patterns implemented elsewhere in the codebase, we seem to be moving towards returning a `NetSuite::Error` if the response is not successful. Solution Return a `NetSuite::Error` if the response is not successful.
|
@Timothyjb where else in the codebase are you seeing this pattern? I think this, combined with something like #405, is the right approach going forward. Just want to think on/validate the approach a bit more when I have some time. |
|
@iloveitaly Would be awesome to see some progress on this after such a long time. We've been running a fork of this repository to get this feature to our production. |
|
@aom Me too! Just time constrained on my end :/ |
|
Going to close this one for now. Depending on how #405 turns out, this may not be necessary. I can probably revisit then. |
|
it would make sense that if doing a search that is rejected to return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, if the response of the
Searchaction is not successful, it will simply returnfalseand give no insight into what the issue was.Looking at patterns implemented elsewhere in the codebase, we seem to be moving towards returning a
NetSuite::Errorif the response is not successful.Solution
Implement returning a
NetSuite::Errorif the response is not successful.